forked from harness/canary
-
Notifications
You must be signed in to change notification settings - Fork 0
Form validation refactoring. Part 2 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankormoreankor
wants to merge
15
commits into
form-error-handling-fix
Choose a base branch
from
form-error-handling-fix-part-2
base: form-error-handling-fix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Form validation refactoring. Part 2 #35
ankormoreankor
wants to merge
15
commits into
form-error-handling-fix
from
form-error-handling-fix-part-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8f36b29 to
a56b668
Compare
d612f1e to
0e8ce7f
Compare
a56b668 to
410574f
Compare
410574f to
527cafc
Compare
0e8ce7f to
5934bae
Compare
527cafc to
4f25196
Compare
8e5ffa3 to
653af1a
Compare
653af1a to
229fcaf
Compare
229fcaf to
bbf43c6
Compare
c7a6c82 to
04dd3b5
Compare
bbf43c6 to
a35658b
Compare
a35658b to
b111435
Compare
04dd3b5 to
99c6f33
Compare
b111435 to
1259dd4
Compare
1259dd4 to
fce1588
Compare
0bc4437 to
0e02f8c
Compare
d40c70a to
2d1b259
Compare
6dcd990 to
8f2f756
Compare
2d1b259 to
b375c88
Compare
7365a97 to
87015b3
Compare
87015b3 to
26aeaf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of forms validation improvement
Optioncomponent can now render an error message the same way as other form fieldsFieldsetcomponent can now render thelegendelement visible only to assistive devices. The legend element is essential for thefieldsetelement