Fix bublikov task 1 #42
Conversation
pbuba
commented
Apr 30, 2025
pbuba
commented
- move DelegateSelectorDrawer to packages/ui/src/views/
- Styled Drawer as figma (Text, layout, gap)
- Fix on top header and on bottom footer
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/ui/src/views/delegates/components/delegate-connectivity-list.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/delegates/delegate-selector-drawer/delegate-selector-drawer.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/delegates/delegate-selector-drawer/delegate-selector-drawer.tsx
Outdated
Show resolved
Hide resolved
| primary ? 'text-3 leading-snug' : secondary ? 'text-2' : 'text-sm', | ||
| 'text-cn-foreground-1 [&>em]:text-cn-foreground-1 font-normal [&>em]:font-medium [&>em]:not-italic', | ||
| !!label && 'text-cn-foreground-2', | ||
| className |
There was a problem hiding this comment.
I know there was an issue with className here, but before removing it, we should check all usages of ListField across the projects
| className={cn( | ||
| '[&_tr:last-child]:border-0', | ||
| { '[&>tr:hover]:bg-cn-background-hover': hasHighlightOnHover }, | ||
| { '[&>tr:hover]:cursor-pointer': hasHighlightOnHover }, |
There was a problem hiding this comment.
This style shouldn’t be applied — hasHighlightOnHover doesn’t always imply a cursor change. It’s just for highlighting rows.
| description={option.description} | ||
| descriptionClassName={cn('leading-tight', { | ||
| 'text-cn-foreground-4': value !== option.value, | ||
| '': option.disabled |
| className={isLoading ? '[mask-image:linear-gradient(to_bottom,black_30%,transparent_100%)]' : ''} | ||
| variant="asStackedList" | ||
| > | ||
| <Table.Root className="table-auto" variant="asStackedList"> |
There was a problem hiding this comment.
We should use tableClassName="table-fixed" and remove all max-w-{{}} from Table.Cell
| return ( | ||
| <Table.Row key={groupId}> | ||
| <Table.Cell className="max-w-28 content-center !py-4"> | ||
| <div className="flex items-center gap-2.5"> |
There was a problem hiding this comment.
Seems like you can remove this div
| </Drawer.Header> | ||
|
|
||
| <Drawer.Inner> | ||
| <div className="px-6 pt-5 leading-[18px]"> |
There was a problem hiding this comment.
Better to avoid custom values — we can use leading-tight here instead
| <Drawer.Close className="sr-only" onClick={() => setOpen(false)} /> | ||
| </Drawer.Header> | ||
|
|
||
| <Drawer.Inner> |
There was a problem hiding this comment.
You can set default paddings in Drawer.Inner, so you don't need to apply padding to each child component individually
