forked from harness/canary
-
Notifications
You must be signed in to change notification settings - Fork 0
Move the usage of use translation store into a context #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pixel-buba
wants to merge
10
commits into
main
Choose a base branch
from
Move-the-usage-of-useTranslationStore-into-a-Context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move the usage of use translation store into a context #47
pixel-buba
wants to merge
10
commits into
main
from
Move-the-usage-of-useTranslationStore-into-a-Context
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pixel-buba
commented
May 19, 2025
- Create TranslationContext, TranslationProvider and useTranslation hook
- update apps for TranslationContext
- repalaced useTranslationStore to useTranslation for all apps
- remove props drilling useTranslationStore for all apps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
65f5254 to
6207c86
Compare
4a14c5c to
b150056
Compare
b19a179 to
f3d3b36
Compare
* add repo name to repo header * fixes * fix header position
* fix: new multiselect onboard to delegate selector form * fix: new multiselect onboard to delegate selector form
f3d3b36 to
0e0e289
Compare
0e0e289 to
5586dc2
Compare
* removed visited token + tooltip tokens review and update * drawer gradient fixes * fix * tooltip border added * px corner radius added * fix
* feat: add component * feat: basic layout working * feat: add docs * feat: fix docs * feat: fix docs * revert: pnpm-lock * fix: minor revert * feat: use cva not maps * fix: revert docs * fix: minor spacing fix * refactor: layout * fix: gap enum * fix: minor changes to api * fix: minor cleanup * chore: rebase * fix: add comment * fix: docs
…props drilling useTranslationStore
5586dc2 to
76fb884
Compare
76fb884 to
d16a3ff
Compare
3em
reviewed
Aug 20, 2025
Comment on lines
5
to
6
| import { useThemeStore } from '@utils/theme-utils' | ||
|
|
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
Suggested change
| import { useThemeStore } from '@utils/theme-utils' | |
| import { useThemeStore } from '@utils/theme-utils' | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.