[wip] in-ns form #506
Open
[wip] in-ns form #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #366
This makes
in-nsjust a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probably to with thedeftestmacro. For example thedefprotocolinside a test broke unless i put a(in-ns ...)before it. Also I had to wrap some code inevalso it would end up in thefoonamespace and not in thepixie.test.test-stdlibnamespace.Ideally we shouldn't have to make the changes I made to the tests. Any thoughts?
Cheers.