fix: AssetWatcher throws an error when spine is exporting files #162
+82
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberDex
changed the title
|
@Zyie please review |
Improves the asset watcher's stability and event handling by debouncing and deduplicating rapid file system events. Adds logic to prevent redundant processing of 'add', 'change', and 'unlink' events when multiple changes occur for the same file in quick succession. This ensures that the watcher only processes the most relevant and final event, resolving issues that arise from rapid file modifications, such as during asset exports. Fixes pixijs#159
|
hey @CyberDex I made a slight change to this PR that still hopefully fixes your issue the concept is still the same but we now ensure all cases are handle rather than just a "change" event let me know if this change works for you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159
Spine can do multiple manipulations with exported files, like:
watcher should only consider the latest change