fix: manifest file sizes for texture packer #163
+417
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the manifest `progressSize` for texture packer assets only reflected the JSON file size, omitting the associated texture image size. This led to inaccurate asset size reporting. Introduces a new `texturePackerManifestMod` pipe that runs after `pixiManifest`. This pipe scans for texture packer atlases, calculates the combined size of their JSON and image files, and updates the manifest accordingly. Extracts the file size calculation logic into a reusable utility function. Changes the `pixiManifest` `includeFileSizes` option default to `false`. Updates the `clean` script to use `rimraf --glob` for improved glob pattern handling. Adds documentation for using the new texture packer manifest modifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the manifest
progressSizefor texture packer assets only reflected the JSON file size, omitting the associated texture image size. This led to inaccurate asset size reporting.Introduces a new
texturePackerManifestModpipe that runs afterpixiManifest. This pipe scans for texture packer atlases, calculates the combined size of their JSON and image files, and updates the manifest accordingly.Extracts the file size calculation logic into a reusable utility function.
Changes the
pixiManifestincludeFileSizesoption default tofalse.Updates the
cleanscript to userimraf --globfor improved glob pattern handling.Adds documentation for using the new texture packer manifest modifier.