Synchronous port removal in audio conference bridge if port is newly added #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
reviewed
Jan 17, 2025
pjmedia/src/pjmedia/conference.c
Outdated
|
|
||
| /* If the add-op is not found, it may be being executed */ | ||
| if (ope == conf->op_queue) | ||
| goto on_return; |
There was a problem hiding this comment.
So how about the removal process itself?
There was a problem hiding this comment.
Nice catch! Should have just been fixed.
… applied for the wrong port which reuses the slot
sauwming
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with asynchronous conference bridge, port removal can only be done in the conference clock. This PR allows synchronous port removal for newly added port. Sample use case is when conference bridge has no clock (e.g: no sound device), without this the conference bridge slots will get full and never been able to be freed.