Various fixes for Apple SSL backend #4257
Open
+45
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several problem found in Apple SSL backend:
Warning: Failed to cancel SSL connection
. This may cause access to its already destroyed parent SSL socket. Switching from serial to concurrent queue seems to fix the issue and the connection cancellation seems to never fail now.nw_connection_receive()
.Server socket:
ssock->param.require_client_cert
).SSL test:
PJ_SSL_SOCK_DELAYED_CLOSE_TIMEOUT
.