Fixed timer remove node safeguard #4259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the timer use copy (PJ_TIMER_USE_COPY), we can detect if original entry has been deallocated by comparing if the copy differs from the original entry.
This is supposed to be a safeguard that can help detect hard-to-find bug and prevent it from crashing (we will write warning log instead). Unfortunately, we still overwrite the original entry, and the crash would still occur.
Example log:
Here we overwrite a memory location which has been deallocated and used by another object.