-
-
Notifications
You must be signed in to change notification settings - Fork 73
Save headers from CONNECT response in HttpProxyConnectResponseHeaders extension. #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me, please do address comments, once that is done we can merge this swiftly, def. do not forget about motivations
rama-http-backend/src/client/proxy/layer/proxy_connector/connector.rs
Outdated
Show resolved
Hide resolved
rama-http-backend/src/client/proxy/layer/proxy_connector/service.rs
Outdated
Show resolved
Hide resolved
rama-http-backend/src/client/proxy/layer/proxy_connector/service.rs
Outdated
Show resolved
Hide resolved
`Debug`, `AsRef`, `AsMut`, `Deref` and `DerefMut` impls.
rama-http-backend/src/client/proxy/layer/proxy_connector/service.rs
Outdated
Show resolved
Hide resolved
`HttpProxyConnectResponseHeaders`.
rama-http-backend/src/client/proxy/layer/proxy_connector/service.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @maartendeprez ; once CI passes it can be merged
This can be used, for example, to copy headers from the CONNECT response to proxied responses.