Skip to content

Make run android #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Make run android #42

merged 2 commits into from
Oct 28, 2024

Conversation

nkmrh
Copy link
Contributor

@nkmrh nkmrh commented Oct 26, 2024 •
edited
Loading

Summary

Implementation

Test plan

Other Information

  • example プロジェクトをflutter run コマンドから android をビルドできるように下記変更をしました
    • compileSdkVersion を 34 に変更しました
    • kotlin version を 1.7.0 に変更しました

@nkmrh nkmrh self-assigned this Oct 26, 2024
@nkmrh nkmrh requested a review from harukitosa October 26, 2024 03:13
harukitosa
harukitosa approved these changes Oct 28, 2024
View reviewed changes
Copy link

@harukitosa harukitosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

@nkmrh nkmrh merged commit 32d0772 into master Oct 28, 2024
1 check passed
@nkmrh nkmrh deleted the make-run-android branch October 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harukitosa harukitosa harukitosa approved these changes

Assignees

@nkmrh nkmrh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkmrh @harukitosa