Skip to content

Flutter 3.29に対応するため、registerWithを削除 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

paigupai
Copy link
Contributor

Summary

flutter 3.29 AndroidのPluginRegistry.Registrarが廃止されましたので、buildできないになっています。

Implementation

Test plan

Other Information

@paigupai paigupai marked this pull request as draft February 27, 2025 05:37
@paigupai paigupai marked this pull request as ready for review February 27, 2025 08:02
@paigupai paigupai force-pushed the android_registrar_fix branch from f656d7a to e55fc3d Compare February 27, 2025 10:28
@paigupai
Copy link
Contributor Author

paigupai commented Feb 28, 2025

Flutter 3.29 では、io.flutter.app が存在しない問題が発生します。
Application.kt ファイルで FlutterApplication() を拡張することができません。
以下に修正しないと、build出来ません。

class YourApplication : FlutterApplication() {
  override fun onCreate() {
    super.onCreate()
    KarteApp.setup(this, "アプリケーションキー")
  }
}

class YourApplication : android.app.Application() {
  override fun onCreate() {
    super.onCreate()
    KarteApp.setup(this, "アプリケーションキー")
  }
}

ただこの修正、影響が分からないので、公式の対応待ちにした方がいい
参考
flutter/flutter#164024 (comment)

Copy link
Contributor

@TakayukiCho TakayukiCho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@TakayukiCho TakayukiCho merged commit 80ed075 into plaidev:master Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants