Skip to content

Conversation

@dimarobert
Copy link
Contributor

No description provided.

…This code is obtained from the samples supplied by iText.
…rogrammatically and storing the certificate chain.
…ave signature classes implement the IExternalSignatureWithChain.
Needed to be able to connect from the javascript in the page to the localhost.
Comment on lines +6 to +11
<Company>PlantAnApp, iText Group</Company>
<Authors>Plant An App, iText Group</Authors>
<Copyright>(C) Plant An App, (C) iText Group</Copyright>
<PackageLicenseFile>C:\Work\Projects\PdfAutoSignerAndJava\_code\PlantAnApp.PdfAutoSigner\license.rtf</PackageLicenseFile>
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
<RepositoryUrl>https://github.com/razvanionapp/PlantAnApp.PdfAutoSigner.git</RepositoryUrl>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should be updated.

Comment on lines +10 to +11
**/hello-signed-pkcs11.pdf
**/hello-signed-cert.pdf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should have these here.

Comment on lines +60 to +61
byte[] buffer = new byte[file.Length];
buffer = outputMemStream.ToArray();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
byte[] buffer = new byte[file.Length];
buffer = outputMemStream.ToArray();
byte[] buffer = outputMemStream.ToArray();

return BadRequest("A signature must be selected.");
}

var inputMemStream = new MemoryStream();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be closed / disposed at some point. (why not create it with a using statement?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants