-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Plug Devices as Power Strip Accessory in HomeKit #341
Open
ZeliardM
wants to merge
38
commits into
plasticrake:main
Choose a base branch
from
ZeliardM:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plasticrake,
I have tried my hand at working with your API and your plugin for TPLink Smarthome for Homebridge and first and foremost, it was very well done, and I thank you for your work.
I have made several modifications here to implement sending Multi-Plug Devices to HomeKit as a Power Strip Single Grouped Accessory with the Outlets being individually controlled.
The way your API is written, it will allow for childId's to be used, but only when coming from a Plug Device, but sense the Plugs are all just services underneath a single device, I had to work with what I had.
There may be some changes that can be done on the API side of things to work with powerStrips and have them as a deviceType, but I didn't want to mess with the API.
The changes create a single homebridge and homekit accessory, they add multiple outlet services for each outlet and then allow for those outlets to be controlled individually either in the Kasa App, Homebridge, or HomeKit and the state will update across all areas.
I also looked into several of the open issues right now with the ECONNRESET issues and I found that changing over to UDP as the transport resolved those issues, not sure if that fixes the issue, but it stops the logs. I also removed the energy characteristics from default as they are listed under the HomeKit as optional and not required or used in HomeKit, they can still be enabled, but just disabled by default.
If you have any questions about this, please let me know.