Handle Rule Conflicts #1192
Merged
Handle Rule Conflicts #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he conflicting settings have been corrected as well as prompting the user around whether to disable a rule or not when they try to enable a rule and have a conflict
pjkaufman
added
the
rule conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1187
Fixes #911
Fixes #856
Some rules do not play well together. So they need to not be enabled at the same time. Thus logic has been added so that when one of these scenarios happens the other rule is disabled.
If a user enables Insert File Name, and Header Increment Starts at H2 is enabled it will ask if the user wants Starts at H2 to be turned off or if they want to cancel their action and vice versa.
If a user enables Paragraph Blank Lines and Line Break Between Lines with Content is enabled, it will ask if the user wants Line Break Between Lines with Content to be turned off or if they want to cancel their action and vice versa.
On startup, there will be changes that disable Header Increment Starts at H2 and Paragraph Blank Lines if their conflicting rule is enabled. A notice will explain the situation and the user can go to the settings to make a change if they would like.