Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add Blank Line After YAML Only Working When YAML Already Exists #1200

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #1188
Relates to #1199

There was an issue with running the Linter rule Add Blank Line after YAML where it was not adding a blank line after the YAML if it was added by say YAML Timestamp. The issue was caused by the YAML being added long after the rule had run. This meant it could not add the blank line. To fix this, the rule needs to run before YAML Timestamp if the YAML is present since there could be a modification that needs to cause a timestamp update. However if there is no YAML frontmatter present, then it can run after YAML Timestamp since it will either create the frontmatter or no frontmatter will exist by the time the Linter's rules run.

There was also a change to make the release compiled version of the plugin be 16.x since that is the minimum version that should be supported by plugins at this time.

There was also a small fix of a typo in a setting's wording.

It also adds a fix to the minification of the styles which was previously not merged due to the gitignore.

Changes Made:

@pjkaufman pjkaufman added bug Something isn't working obsidian Obsidian specific syntax issue or feature github rule conflict 2 rules are conflicting with each other which is causing the reported behavior wording update This means that the fix or at least part of the fix is related to a wording change for the settings labels Oct 21, 2024
@pjkaufman pjkaufman self-assigned this Oct 21, 2024
@pjkaufman pjkaufman merged commit a88b2e9 into platers:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github obsidian Obsidian specific syntax issue or feature rule conflict 2 rules are conflicting with each other which is causing the reported behavior wording update This means that the fix or at least part of the fix is related to a wording change for the settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Space after frontmatter is not respected when frontmatter is created
1 participant