chore: refactor runLinterFile to use vault.process for more safety #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @kdnk , sorry about the delay in responding to this PR. I do like the idea of doing this. And it is likely something we should do. I am just not 100% on board with doing this right now since I am off and on working on getting the logic to run in an async way. This would mean that we would have to get rid of the Hopefully that makes sense while I think this over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
this.app.vault.processfor more safe file modifications.ref. https://youtu.be/RvtV9DKr3ag?si=ch9cn9T0HMlNtoGg&t=52
ref. https://docs.obsidian.md/Plugins/Vault#Modify+files