fix: correct regex pattern for title matching in yaml-title rule #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nshcr , this looks good to me. Thanks for taking the time to fix this. I will go ahead and merge this since it looks to be passing UTs and does not look like it would cause any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yaml-title rule adds a title key to the frontmatter or replaces it if it already exists.
I noticed that if other keys start with the title key (e.g., titleTemplate, one of the VitePress's frontmatter config), they might be incorrectly replaced — especially if they appear before title.
So I updated the regex to match the exact title key and avoid this issue.
Thanks for reviewing.