fix: consider checking params in checkCallback

[kdnk]

Fix #1315 (comment)

ref. #1314

[pjkaufman]

Thanks for the changes. There are just a couple of recommended changes.

[pjkaufman]

I believe true should only be returned here if the active file is not null/the editor exists. Checking determines if the command should show.

[kdnk]

This command is overriding editor:save-file, so I'm starting to think that the condition returning true and "lint on save is enabled" are unrelated. In other words, the condition that returns true should be outside the if statement for lintOnSave and isEnabled.

What do you think?

[kdnk]

I think we should respect the original checkCallback in editor:save-file while checking, so the following code makes sense to me. WDYT?

        if (checking) {
          return this.originalSaveCallback(checking);
        } else {
          const editor = this.getEditor();
          const file = this.app.workspace.getActiveFile();
          if (this.settings.lintOnSave && this.isEnabled) {
            if (editor) {
              if (!this.shouldIgnoreFile(file) && this.isMarkdownFile(file) && editor.cm) {
                void this.runLinterEditor(editor);
              }
            }
          }
        }

[pjkaufman]

The checking status should really be handled at the start of the function. If we are checking, we should go ahead and just check right after the logic for running the original callback. If we are checking, we should return whatever the original callback returns. Otherwise we proceed as normal.

[pjkaufman]

I like the change you posted above for the code.

[kdnk]

@pjkaufman Thank you!
I committed the changes. Could you review this PR again?

[pjkaufman]

No problem. I just did put in another review.

[pjkaufman]

Looks like there are two lint issues plus a change in the actual meaning of the save callback logic added by the Linter.

[pjkaufman]

The logic here should be the same as the original to avoid trying to act on null or undefined files:

 if (this.settings.lintOnSave && this.isEnabled) {
          const editor = this.getEditor();
          if (editor) {
            const file = this.app.workspace.getActiveFile();
            if (!this.shouldIgnoreFile(file) && this.isMarkdownFile(file) && editor.cm) {
              if (!checking) {
                this.runLinterEditor(editor);
              }
              return true;
            }
          }
        }
      };

[pjkaufman]

Looks good. Thanks for making this change.