Add a 'Suppress message if no change' feature with settings. #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(settings): add option to hide notice when no change Introduce a new setting noNoticeWhenNoChange to control whether the post-lint notice is shown when no characters are added or removed. - Add noNoticeWhenNoChange to settings data and default values, with comments. - Persist and normalize the setting during loadSettings to ensure a boolean default. - Add a ToggleSetting in the General tab UI and include localization entries (en, zh-cn) for name and description. - Update displayChangedMessage to respect the new setting and skip showing the notice when no chars were added/removed. This reduces noise for users who prefer no feedback when linting makes no effective changes. * feat(locale): add more translations - Translated by AI * refactor: rename variable name Update settings, usage and translations to use a clearer name for the option that suppresses messages when there are no actual changes. - Rename settings property in loadSettings from noNoticeWhenNoChange to suppressMessageWhenNoChange and default it to false. - Update displayChangedMessage to read suppressMessageWhenNoChange and skip message emission when chars added + removed is zero. - Update translation keys and copy in ru, tr, de, es locales from no-notice-when-no-change to suppress-message-when-no-change and adjust wording to match the new name. - Remove a now-duplicate UI setting block in general-tab that created the old toggle for noNoticeWhenNoChange (the UI now uses the renamed setting elsewhere). This clarifies intent (suppress message vs. no notice) and consolidates the implementation to the new, consistent setting name.
Adjust the constructor call and remove stray whitespace in the general tab component to match expected parameter formatting. - Remove an extra blank character left after a conditional block. - Add a missing trailing comma for the plugin argument in the ToggleSetting constructor call to ensure consistent argument separation and avoid potential lint/format issues. These small fixes improve code style consistency and prevent minor syntax/formatting problems in the UI linter component.
pjkaufman
requested changes
Sep 10, 2025
Collaborator
pjkaufman
left a comment
pjkaufman
left a comment
There was a problem hiding this comment.
Other than passing in the string references as any this looks good to me. If you could remove the as any then I can merge this. Otherwise I can remove the as any if I do not hear back or if that is easier.
| } | ||
|
|
||
| tempDiv = this.contentEl.createDiv(); | ||
| const suppressMessageWhenNoChangeSetting = new ToggleSetting( tempDiv, 'tabs.general.suppress-message-when-no-change.name' as any, 'tabs.general.suppress-message-when-no-change.description' as any, 'suppressMessageWhenNoChange', this.plugin); |
Collaborator
There was a problem hiding this comment.
Could you explain the use of as any here? The other areas are not using as any. So this implies that it was either an accidental addition or the string provided does not map properly for the English translation.
Contributor
Author
There was a problem hiding this comment.
Could you explain the use of
as anyhere? The other areas are not using as any. So this implies that it was either an accidental addition or the string provided does not map properly for the English translation.
Oh, sorry for late replying! I'll try to update this commit, but I'm worried about causing issues with multi-branch operations (just like last time...).
If I don't succeed, feel free to remove this as any :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the new version with settings of #1286
I'm sorry I forgot about this earlier... Since there were some issues with the original PR (my merge operation caused a mess), I'm opening a new one now.
It now has separate settings, disabled by default: