Skip to content

Conversation

@kekcleader
Copy link
Contributor

@kekcleader kekcleader commented Oct 28, 2025

#62

The account controller tests were refactored to use multicluster-provider/envtest instead of the deprecated pkg/testing package. However, the following tests are skipped due to their dependency on workspace-related subroutines requiring direct access to the KCP Workspace CRD:

  • TestAddingFinalizer: Finalizer management (workspace + accountinfo finalizers)
  • TestWorkspaceCreation: Workspace creation via WorkspaceSubroutine
  • TestAccountInfoCreationForOrganization: AccountInfo resource creation
  • TestWorkspaceFinalizerRemovesWorkspace: Workspace cleanup on account deletion

Reason for skipping: The Workspace and AccountInfo subroutines need direct access to the KCP’s built-in Workspace CRD, which isn’t exposed through the APIExport virtual workspace endpoint used by the multicluster manager.

Issue: The multicluster test setup provides access only to custom resources (Account, AccountInfo) through the APIExport endpoint, while KCP’s built-in resources (Workspace, WorkspaceType) are not available.

Root Cause:

  • apiexport.Provider connects to the APIExport virtual workspace, which exposes only custom CRDs (Account, AccountInfo).
  • KCP’s built-in resources (Workspace) are not included, causing subroutines to fail when trying to create informers for Workspace resources.

@kekcleader kekcleader self-assigned this Oct 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/refactor-e2e-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the fix label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants