Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Commit

Permalink
Update themes on config changes (#793)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mattlyons0 @ivankravets
mattlyons0 authored and ivankravets committed Oct 14, 2019
1 parent c85b636 commit bc5819b
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/view.coffee
View file
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,11 @@ class PlatformIOTerminalView extends View
config = atom.config.get 'platformio-ide-terminal'

@xterm.addClass config.style.theme

@subscriptions.add atom.config.onDidChange 'platformio-ide-terminal.style.theme', (event) =>
@xterm.removeClass event.oldValue
@xterm.addClass event.newValue

@xterm.addClass 'cursor-blink' if config.toggles.cursorBlink

editorFont = atom.config.get('editor.fontFamily')
Expand Down

2 comments on commit bc5819b

@the-j0k3r
Copy link
Collaborator

@the-j0k3r the-j0k3r commented on bc5819b Oct 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivankravets this works 100% as advertised.

Please push a new release which will also force the prebuilt modules to be installed for the new Atom 1.41.0 rather then old prebuitlt modules.

For some reason when Atom upgrades from 1.40.1 electron 3.x to Atom 1.41.0 electron 4.x, the new prebuilt modules for electron 3.x are left in node_modules the only recourse is delete that folder and reinstall, unless theres a new release when Atom 1.41.0 is already installed.

Theres no way around it in any case, a small protion of our users will be caught by this issue because node-gyp is buggy.

This PR and other works lovely though.

@ivankravets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done! https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.10.0

Please sign in to comment.