fix: ENVIRONMENT_TYPE needs to be used to check onProduction() #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiaz
force-pushed
the
mr/matthias/fix-environment-type-with-backwards-compatibility-in-mind
branch
4 times, most recently
from
632315e to
5beb7fc
Compare
This was referenced Feb 12, 2025
matthiaz
force-pushed
the
mr/matthias/fix-environment-type-with-backwards-compatibility-in-mind
branch
from
5beb7fc to
917621a
Compare
matthiaz
force-pushed
the
mr/matthias/fix-environment-type-with-backwards-compatibility-in-mind
branch
from
917621a to
26fe9f4
Compare
flovntp
reviewed
Feb 17, 2025
| return $this->getValue('ENVIRONMENT_TYPE') == 'production'; | ||
| } else { | ||
| // legacy way of checking production type | ||
| $prodBranch = $this->onDedicated() ? 'production' : 'master'; |
Contributor
Author
There was a problem hiding this comment.
well yeah, that's the backwards compatibility. Ideally we won't ever get into this else statement. But if we do, the functionality needs to be the same.
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Which allows onProduction to correctly identify the production environment, without having to be named 'master'
This issue is fairly old, and an attempt was made to fix this in #22
However, backwards compatibility was not maintained in there.
This PR tries to address that backwards compatibility, so this should work for old and new environments.