Skip to content

Fix service selection to support internal storage services #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix service selection to support internal storage services #1575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Command/Metrics/MetricsCommandBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,13 @@ protected function fetchMetrics(InputInterface $input, TimeSpec $timeSpec, Envir
$servicesInput = ArrayArgument::getOption($input, 'service');
$selectedServiceNames = [];
if (!empty($servicesInput)) {
$selectedServiceNames = Wildcard::select(array_merge(array_keys($allServices), ['router']), $servicesInput);
// Build a list of selectable service names, including internal storage services.
$selectableServiceNames = array_merge(array_keys($allServices), ['router']);
// Add internal storage services for each webapp.
foreach (array_keys($deployment->webapps) as $appName) {
$selectableServiceNames[] = $appName . '---internal---storage';
}
$selectedServiceNames = Wildcard::select($selectableServiceNames, $servicesInput);
if (!$selectedServiceNames) {
$this->stdErr->writeln('No services were found matching the name(s): <error>' . implode(', ', $servicesInput) . '</error>');
return false;
Expand Down
Loading