backport (4.x): Display failing activities as failing in CLI #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR backports functionality to display failing activities correctly in the CLI by checking command exit codes. When any command within an activity has a non-zero exit code, the activity result is now displayed as "failure" regardless of the activity's reported result field.
Key Changes:
- Modified
formatResult()to accept an Activity object instead of a string result value - Added logic to inspect command exit codes and override the result to "failure" when any command fails
- Updated all call sites to pass the full Activity object instead of just the result string
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Service/ActivityMonitor.php | Core logic change: formatResult() now inspects activity commands and overrides result based on exit codes |
| src/Command/Integration/Activity/IntegrationActivityListCommand.php | Updated to pass Activity object to formatResult() |
| src/Command/Environment/EnvironmentDeployCommand.php | Updated to pass Activity object to formatResult() |
| src/Command/Activity/ActivityListCommand.php | Updated to pass Activity object to formatResult() |
| src/Command/Activity/ActivityGetCommand.php | Updated to pass Activity object to formatResult() and handle result property specially |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1572 to
main(4.x version, theoretically compatible with PHP 5.6+)