Skip to content

schema: allow integer in "expires" values #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

schema: allow integer in "expires" values #246

merged 1 commit into from
May 19, 2025

Conversation

@pjcdawkins
Copy link
Contributor

@pjcdawkins pjcdawkins commented May 16, 2025

This field allows an integer, meaning seconds (and even the default is an integer -1 in some cases)

  • check this in the git source

akalipetis
akalipetis approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit c02c91d into main May 19, 2025
3 checks passed
@akalipetis akalipetis deleted the fix-schema-expires-can-be-int branch May 19, 2025 09:59
@akalipetis akalipetis mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akalipetis akalipetis akalipetis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pjcdawkins @akalipetis