Skip to content

Conversation

@gilzow
Copy link
Contributor

@gilzow gilzow commented Dec 2, 2022

Updates the remaining PHP7.4 templates to PHP8.1, part 2 and conclusion of #703. These all fail in their composer update step during the build OR the PR fails

Fail during composer update

  • Drupal8 Multisite - see below
  • Drupal8 Opigno - see below
  • Drupal8 - see below
  • Pimcore

Composer update succeeds but environment builds fail

Regression introduced from template builder update

  • Drupal Gatsby - I end up with both a drupal directory AND an api directory in the template builder build.

@gilzow
Copy link
Contributor Author

gilzow commented Dec 2, 2022

Summary: None of the drupal8 templates will be able to update PHP past 7.4.

drupal/core-recommended @ 8.9.20 is pinned to composer/semver @ 1.5.1.
composer/semver requires PHP ^5.3.2 || ^7.0

drupal/core-recommended @ 8.9.20 is pinned to doctrine/annotations @ 1.4.0.
doctrine/annotations @ 1.4.0 requires "php": "^5.6 || ^7.0",

@gilzow
Copy link
Contributor Author

gilzow commented Dec 2, 2022

Summary: This version of pimcore will not be able to update PHP past 7.4
pimcore/skeleton @ 2.7.3 requires codeception/codeception @ ~2.4.5
codeception/codeception @ 2.5.6 (last in the 2.X branch) requires "php": ">=5.6.0 <8.0"

@gilzow
Copy link
Contributor Author

gilzow commented Dec 5, 2022

Decision has been made to archive all Drupal8-based templates.

@gilzow
Copy link
Contributor Author

gilzow commented Dec 5, 2022

For nextcloud, there was a regression in the cron syntax that caused the app.yaml parsing to fail. However, once I corrected it, the application notified me:

This version of Nextcloud is not compatible with > PHP 7.4.
You are currently running 8.1.12.

So it appears that the current instance of the nextcloud template can not be updated to anything beyond PHP7.4.

@gilzow
Copy link
Contributor Author

gilzow commented Dec 5, 2022

Typo3 was failing due to old cron syntax, as that PR hasn't been merged yet. However, once I updated the cron syntax I get the following error during the build hook:

PHP Fatal error:  Declaration of TYPO3\CMS\Core\Database\Driver\PDOStatement::fetchAll($fetchMode = null, $fetchArgument = null, $ctorArgs = null) must be compatible with Doctrine\DBAL\Driver\PDOStatement::fetchAll($mode = null, ...$args) in /app/public/typo3/sysext/core/Classes/Database/Driver/PDOStatement.php on line 67

The current instance of the Typo3 template is on v10; the latest is v12.

@gilzow
Copy link
Contributor Author

gilzow commented Dec 9, 2022

Summary: archive the following templates

  • Pimcorev2.7
  • Typo3v10
  • NextCloud v20

For Typo3, according to the documentation, v10 does not support PHP 8.0, or 8.1. Decision has been made to remove it from this PR, and then archive the template.

Later versions of NextCloud require a database account that has all privileges including grant options. According to internal resources, we do not grant db accounts all privileges, nor do we include grant options. Decision has been made to remove it from this PR, and then archive the template.

Pimcore at v2.7 does not support PHP 8.0 or 8.1. Decision has been made to remove it from this PR, and then archive the template.

@gilzow
Copy link
Contributor Author

gilzow commented Dec 9, 2022

Given the above, closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants