Skip to content

Update containerDeployment.yml #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Update containerDeployment.yml #13

merged 1 commit into from
Apr 21, 2025

Conversation

aminespinoza10
Copy link
Collaborator

This pull request updates the .github/workflows/containerDeployment.yml file to enhance the container deployment workflow by removing unnecessary steps and adding Docker Hub integration.

Workflow improvements:

  • Removed the redundant "Looking for files" step that listed all files in the repository.
  • Added Docker Hub integration with a new "Login to Docker Hub" step, using the docker/login-action@v2 action and credentials from GitHub secrets.
  • Introduced a "Deploy image to hub" step to push the Docker image to Docker Hub after building it.

Closes #12

@aminespinoza10 aminespinoza10 requested a review from gndx April 21, 2025 17:52
@aminespinoza10 aminespinoza10 self-assigned this Apr 21, 2025
Copy link
Member

@gndx gndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aminespinoza10 aminespinoza10 merged commit 7700d3d into main Apr 21, 2025
1 check passed
@aminespinoza10 aminespinoza10 deleted the amines/12 branch April 21, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establecer CD para Docker
2 participants