Remove total_visitors metric from dashboard breakdown reports #5058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metric was only shown in some details modals and with scroll depth goals incoming cause confusion and complexity. Long-term we plan to show the fraction(s) in tooltips.
|
RobertJoonas
approved these changes
Feb 12, 2025
| @@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| - Internal stats API routes no longer support legacy dashboard filter format. | |||
| - Dashboard no longer shows "Unique visitors" in top stats when filtering by a goal which used to count all users including ones who didn't complete the goal. "Unique conversions" shows the number of unique visitors who completed the goal. | |||
| - Dashboard no longer shows "Total visitors" in breakdown details modals. | |||
There was a problem hiding this comment.
Suggested change
| - Dashboard no longer shows "Total visitors" in breakdown details modals. | |
| - Goal-filtered dashboard no longer shows "Total visitors" in breakdown details modals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This metric was only shown in some details modals and
with scroll depth goals incomingIMO cause confusion and complexity.Long-term we plan to show the fraction(s) in tooltips.
Follow-up to #4999
Tests
Changelog
Documentation
Dark mode