play-java-streaming-example: Add csp nonce #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport 2.9.x |
✅ Backports have been created
|
mkurz
force-pushed
the
fix-play-java-streaming-example
branch
2 times, most recently
from
9ca39dc to
acfab0d
Compare
mkurz
force-pushed
the
fix-play-java-streaming-example
branch
from
acfab0d to
746c8b6
Compare
|
I tried to fix this in separated branch isn't related with my Gradle branches and you could just force push my branch and don't spend a time for new PR 😉 Anyway, It is LGTM 👍 |
I know, I just started the example locally to see what's going on without your changes and then started to migrate the Scala code to Java and then just fixed the rest like you did, didn't take so much time, don't worry 😉 |
mkurz
force-pushed
the
fix-play-java-streaming-example
branch
from
746c8b6 to
368ac27
Compare
ihostage
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Comet this depends on
which will be part of Play 3.0.1/2.9.1