Make RenderTemplate arguments transient for serialization-based caches#1559
Open
megamattron wants to merge 1 commit intoplayframework:masterfrom
Open
Make RenderTemplate arguments transient for serialization-based caches#1559megamattron wants to merge 1 commit intoplayframework:masterfrom
megamattron wants to merge 1 commit intoplayframework:masterfrom
Conversation
…alization-based caches When using @CacheFor with Redis or Memcached, RenderTemplate objects fail to serialize because the arguments map often contains non-serializable objects. Since the template is already rendered into the content field by construction time, and apply() only uses content and name, the arguments field is safely marked transient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks the
argumentsfield inRenderTemplateastransientso that@CacheForworks with serialization-based cache backends (Redis, Memcached).The
argumentsmap often contains non-serializable objects, causing serialization failures whenCache.set()is called inActionInvoker. This is safe because by construction time the template is already rendered into thecontentfield, andapply()only usescontentandname.I have been using this change in production for several years to cache fully rendered output on heavy pages.
Fixes #1558