1556 : Update PlayJUnitExtension.java with new implementation#1560
Draft
xael-fry wants to merge 1 commit intoplayframework:masterfrom
Draft
1556 : Update PlayJUnitExtension.java with new implementation#1560xael-fry wants to merge 1 commit intoplayframework:masterfrom
xael-fry wants to merge 1 commit intoplayframework:masterfrom
Conversation
xael-fry
changed the title
xael-fry
force-pushed
the
fix/tests-play-thread
branch
from
cad3996 to
83c944e
Compare
aleksandy
reviewed
Mar 2, 2026
|
|
||
| public static boolean useCustomRunner = false; | ||
|
|
||
| private static final ThreadLocal<Invoker.InvocationContext> invocationContext = ThreadLocal.withInitial(() -> null); |
Contributor
There was a problem hiding this comment.
ThreadLocal<Invoker.InvocationContext> invocationContext = new ThreadLocal();
aleksandy
reviewed
Mar 2, 2026
| Play.init(new File("."), getPlayId()); | ||
| } | ||
| // Store invocation context in ThreadLocal for use in interceptTestMethod | ||
| invocationContext.set(new Invoker.InvocationContext(invocationType)); |
Contributor
There was a problem hiding this comment.
In my opinion you should add a symmetrical afterEach() method, which will clear the threadlocal variable using invocationContext.remove().
aleksandy
suggested changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #xxxx
Purpose
What does this PR do?
Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?