Skip to content

Fix vx mask tail #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Fix vx mask tail #36

merged 1 commit into from
May 12, 2025

Conversation

XYenChi
Copy link
Collaborator

@XYenChi XYenChi commented May 12, 2025

Set _m as tama.
Set 1s for tail agnostic mask agnostic.

Copy link
Member

@lazyparser lazyparser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩紧格式不对,需要fix下。

另外,这个 fix patch,在 apply 之前和之后, 回归测试没有变化?这就说明回归测试不全。

以后需要注意 fix patch,那么应该是在 apply 之前,有至少一个 test case(s) 是 fail 的;fix之后,从 fail 变成 pass

@lazyparser
Copy link
Member

每一次更新代码 fix 都需要补充。否则又会陷入新fix引发了新bug的无穷循环中。

@lazyparser lazyparser merged commit 3f5db38 into plctlab:develop May 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants