breaking: Remove support for legacy annotations #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
force-pushed
the
remove-legacy
branch
10 times, most recently
from
914a3c9 to
57a7d8c
Compare
|
Thanks for the PR! I announced this upcoming breaking change in the latest release notes. I haven't had a chance to review in detail yet but it's good to see so many deleted lines. |
mrueg
force-pushed
the
remove-legacy
branch
2 times, most recently
from
99d81c1 to
9e28928
Compare
|
Going to wait one more release cycle before merging, just to give people adequate time to migrate. |
|
I think we're in the clear to include this in the next release. @mrueg can you rebase and confirm the tests run successfully? |
|
@mrueg Friendly ping |
BREAKING CHANGE!!
|
@jalseth sorry missed the first ping. I ran the tests locally and they seem to work fine. |
jalseth
approved these changes
May 4, 2025
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the support for all legacy annotations (the ones starting with
@), as they have been marked as legacy since 2 years.Fixes: #297