Implement Recycle Bin #4168

rohnsha0 · 2025-04-29T14:02:27Z

ref #2966

to be merged together:-

plone.base - #81
plone.app.discussion - #264

replaces #4166

…tions Control Panel

Co-authored-by: Steve Piercy <[email protected]>

mister-roboto · 2025-04-29T14:02:39Z

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy

Refactor recyclerbin to recyclebin. I missed this on my previous pass.

Products/CMFPlone/controlpanel/browser/configure.zcml

Products/CMFPlone/controlpanel/browser/recyclerbin.py

Products/CMFPlone/profiles/dependencies/registry.xml

Products/CMFPlone/recyclebin.py

Products/CMFPlone/tests/test_recyclebin.py

stevepiercy · 2025-04-29T19:46:17Z

@rohnsha0 can you check the failing CI checks from meta? Let us know if you have any questions about it.

stevepiercy · 2025-04-29T19:57:35Z

@rohnsha0 here's one problem.

https://github.com/plone/Products.CMFPlone/actions/runs/14733219302/job/41352593835?pr=4168#step:7:70

error: cannot format Products/CMFPlone/browser/recyclebin.py: Cannot parse for target version Python 3.8: 77:67:         message = f"{restored_count} item{'s' if deleted_count != 1} restored successfully."

I think we need to change that, as it appears to have support only since Python 3.12, according to PEP 701. Bummer.

Confirmed by https://github.com/plone/Products.CMFPlone/actions/runs/14733219302/job/41352596237?pr=4168#step:7:773.

rohnsha0 · 2025-05-06T16:49:09Z

hmmm... strangely the jenkins complains of news entry...

edit: also noticed the same issue in a volto PR, see plone/volto#5090 (comment)

rohnsha0 · 2025-05-06T16:52:13Z

also i am not sure how to test PR from plone.base and this pr together :(

stevepiercy · 2025-05-06T19:03:51Z

Jenkins or mr-roboto's change log verifier are not well. @gforcada @plone/ai-team can you look into the failure?

See also:

petschki · 2025-05-07T10:12:20Z

also i am not sure how to test PR from plone.base and this pr together :(

If you login to jenkins.plone.org you can visit this link https://jenkins.plone.org/job/pull-request-6.2-3.10/build?delay=0sec (or go to the "Pull Request 6.x" Job and klick "Build with Parameters" in the menu on the left) ... now you have a textfield where you enter every PR url you want to include in your job ... each line an url.

NOTE: the state of the jenkins jobs are reported back to the PRs automatically ... you see it in the checklist on the bottom)

ale-rt · 2025-05-08T07:55:07Z

I left some comments in another PR that got closed #4166 (comment)
Did you consider them @rohnsha0?

rohnsha0 · 2025-05-09T04:14:59Z

I left some comments in another PR that got closed #4166 (comment) Did you consider them @rohnsha0?

i am done implementing z3c.form as suggested. trying to move presentation logics to p.a.layout

rohnsha0 · 2025-05-09T04:16:53Z

@ale-rt i noticed only core presentations are placed in p.a.layout. i did not find any controlpanel thing in there... i am not super sure what to do!

jensens · 2025-05-09T09:32:23Z

@ale-rt i noticed only core presentations are placed in p.a.layout. i did not find any controlpanel thing in there... i am not super sure what to do!

Controlpanel goes into https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/controlpanel/browser

…onal child processing

davisagli · 2025-05-11T01:43:53Z

Hi @rohnsha0 -- thanks for your diligent work so far.

Tomorrow I plan to test some edge cases. I will also record a video to show to a UX expert our company works with, to see if he has any suggestions.

…ring restore

davisagli · 2025-05-11T23:37:44Z

@rohnsha0 Here are the issues I found while testing:

rohnsha0 · 2025-05-17T04:28:59Z

@davisagli I have opened all PRs that fixes the given issues:-

Recycle bin: can't delete an item again after it was restored #4170 ➡️ Fix deletion of items restored from recycle bin in Actions menu plone.app.content#305
Recycle bin: Can't restore item if it's original container no longer exists #4171 ➡️ [RECYCLE BIN] Fixes broken redirection after restoration and handle value-error gracefully if parent is deleted #4175
Recycle bin: can't delete item with a preview image #4172 ➡️ Fix deleting for image set as preview image in page plone.volto#195
Recycle bin: allow non-admins to access the recycle bin? #4173 ➡️ [RECYCLE BIN] Implement permission for accessing recyclebin #4176

davisagli · 2025-05-29T05:47:34Z

Products/CMFPlone/recyclebin.py

+        try:
+            settings = self._get_settings()
+            return settings.recycling_enabled
+        except (KeyError, AttributeError):


This can raise zope.interface.interfaces.ComponentLookupError when this is called while the Plone site is being deleted, so we should also catch that here.

Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 390, in publish_module Module ZPublisher.WSGIPublisher, line 284, in publish Module ZPublisher.mapply, line 98, in mapply Module ZPublisher.WSGIPublisher, line 68, in call_object Module OFS.ObjectManager, line 560, in manage_delObjects Module OFS.ObjectManager, line 417, in _delObject Module zope.event, line 33, in notify Module zope.component.event, line 27, in dispatch Module zope.component._api, line 146, in subscribers Module zope.interface.registry, line 458, in subscribers Module zope.interface.adapter, line 918, in subscribers Module zope.component.event, line 37, in objectEventNotify Module zope.component._api, line 146, in subscribers Module zope.interface.registry, line 458, in subscribers Module zope.interface.adapter, line 918, in subscribers Module Products.CMFPlone.events, line 60, in handle_content_removal Module Products.CMFPlone.recyclebin, line 164, in is_enabled Module Products.CMFPlone.recyclebin, line 156, in _get_settings Module zope.component._api, line 180, in getUtility zope.interface.interfaces.ComponentLookupError: (<InterfaceClass plone.registry.interfaces.IRegistry>, '')

done in fa502d9

… deleting Plone Site

stevepiercy

minor tweaks and a general question about translations and localization of various forms of plurality

stevepiercy · 2025-06-01T11:30:10Z

Products/CMFPlone/browser/recyclebin.py

+
+        message = translate(
+            _(
+                "${count} item(s) restored successfully.",


I know there's a way to use plurals intelligently in translations, but I don't know what that would be. Here's my clueless English attempt.

There might also be something else to handle plurals in translations, but my memory fails me. Here is some reference material.

https://learn.microsoft.com/en-us/globalization/internationalization/pluralization

https://phrase.com/blog/posts/pluralization/

Perhaps @erral has a better idea of how to support localized singular and plural forms?

Suggested change

"${count} item(s) restored successfully.",

"${count} item{count != 1 ? "s"} restored successfully.",

This pluralisation does not work. I tried it, and I just literally get this in the browser:

1 item${count != 1 ? 's'} restored successfully.

When I extract messages with i18ndude, the po files contain this:

msgid "${count} item${count != 1 ? 's'} restored successfully."

You can't really translate that.

zope.i18n has support for plural messages, but this has not been hooked up in Plone as far as I know. Also, it would need changes in i18ndude.

So: it would be nice to have pluralisation at some point, but currently it does not work.

stevepiercy · 2025-06-01T11:43:30Z

Products/CMFPlone/browser/recyclebin.py

+
+        message = translate(
+            _(
+                "${count} item(s) permanently deleted.",


Flagging for pluralization.

stevepiercy · 2025-06-01T11:44:01Z

Products/CMFPlone/browser/recyclebin.py

+
+        message = translate(
+            _(
+                "Recycle bin emptied. ${count} item(s) permanently deleted.",


Flagging for pluralization.

stevepiercy · 2025-06-01T11:56:39Z

Products/CMFPlone/browser/templates/recyclebin.pt

+                    <div class="d-flex justify-content-between align-items-center flex-wrap gap-2">
+                        <div class="btn-group" role="group">
+                            <button type="submit" name="form.buttons.restore" class="btn btn-primary" i18n:translate="">
+                                <span class="ms-1">Restore Selected</span>


Suggested change

Restore Selected

Restore selected

stevepiercy · 2025-06-01T11:56:49Z

Products/CMFPlone/browser/templates/recyclebin.pt

+                                <span class="ms-1">Restore Selected</span>
+                            </button>
+                            <button type="submit" name="form.buttons.delete" class="btn btn-danger" i18n:translate="">
+                                <span class="ms-1">Delete Selected</span>


Suggested change

Delete Selected

Delete selected

stevepiercy · 2025-06-01T11:57:17Z

Products/CMFPlone/browser/templates/recyclebin.pt

+                                    class="btn btn-outline-danger"
+                                    onclick="return confirm(recyclebinEmptyMessage);" 
+                                    i18n:translate="">
+                                <span class="ms-1">Empty Recycle Bin</span>


Suggested change

Empty Recycle Bin

Empty recycle bin

stevepiercy · 2025-06-01T12:02:04Z

Products/CMFPlone/recyclebin.py

+                return f'Comment thread: "{comment_preview}" ({comment_count} comments)'
+            else:
+                return f"Comment thread ({comment_count} comments)"


We have two possible plurals to handle here.

… bin. This avoids having a strange acquisition chain after the item is restored, which then causes a 'has already been deleted' message if you try to delete it again.

davisagli · 2025-06-17T05:54:34Z

@rohnsha0 Here's another thing that didn't quite work like I expected: I created a folder with a page inside, and deleted the folder. Then in the recycle bin I selected the folder and clicked the "Delete Selected" button to delete it permanently. I expected that this would include all children, but afterward the recycle bin still contained the page.

rohnsha0 · 2025-06-17T08:20:40Z

@rohnsha0 Here's another thing that didn't quite work like I expected: I created a folder with a page inside, and deleted the folder. Then in the recycle bin I selected the folder and clicked the "Delete Selected" button to delete it permanently. I expected that this would include all children, but afterward the recycle bin still contained the page.

@davisagli I fixed it, tested it locally and it now works

edit: also included a testcase covering the same!

rohnsha0 · 2025-07-10T13:22:39Z

@jenkins-plone-org please run jobs

rohnsha0 and others added 12 commits April 29, 2025 19:27

Add Recycle Bin control panel and settings configuration

647faa7

Implement Recycle Bin functionality with management views and settings

5f7c305

Add Recycle Bin action to actions.xml

ad85ec8

lint

3389289

Remove obsolete recycle bin event handler code

2b6b7e4

changelog

ad77b73

add tests

f4de4c0

Fix action index in test cases for adding and changing category in Ac…

7a9094c

…tions Control Panel

Refactor button classes in recycle bin template for consistency

52c9e1f

remove dedundant format_date logic

9534b79

ui cleanup

b8cebee

Apply suggestions from code review

5c65330

Co-authored-by: Steve Piercy <[email protected]>

rohnsha0 requested review from davisagli, jensens, mauritsvanrees, pbauer, sneridagh, petschki, tisto, tkimnguyen, gforcada and ale-rt April 29, 2025 14:02

rohnsha0 mentioned this pull request Apr 29, 2025

Implement Recycle Bin #4166

Closed

implement z3c.form

5687b42

stevepiercy requested changes Apr 29, 2025

View reviewed changes

rohnsha0 added 2 commits April 30, 2025 09:25

fix(recyclebin): added support for discussions

28aab1a

feat(recyclebin): enhance comment tree handling with meaningful titles

07fc9b4

rohnsha0 added 2 commits May 9, 2025 18:45

feat(recyclebin): add process_children parameter to add_item for opti…

da965d4

…onal child processing

lint

8c8fb47

rohnsha0 mentioned this pull request May 11, 2025

Unstable behavior from mr.roboto plone/mr.roboto#168

Open

fix(recyclebin): improve error message for missing target location du…

7079b08

…ring restore

rohnsha0 mentioned this pull request May 12, 2025

Fixes TypeError while deleting image, added as preview image in other Page #4174

Closed

davisagli reviewed May 29, 2025

View reviewed changes

fix(recyclebin): dont break when checking is_enabled-recyclebin while…

fa502d9

… deleting Plone Site

rohnsha0 requested a review from davisagli May 30, 2025 02:02

stevepiercy requested changes Jun 1, 2025

View reviewed changes

Remove Acquisition wrapper from object when storing it in the recycle…

be104f9

… bin. This avoids having a strange acquisition chain after the item is restored, which then causes a 'has already been deleted' message if you try to delete it again.

fix(recyclebin): fix childrens not being purged for folders

0d8815c

Merge branch 'master' into rohnsha0-plip-recyclebin

05f5f7d

	"${count} item(s) restored successfully.",
	"${count} item{count != 1 ? "s"} restored successfully.",

	<span class="ms-1">Restore Selected</span>
	<span class="ms-1">Restore selected</span>

	<span class="ms-1">Delete Selected</span>
	<span class="ms-1">Delete selected</span>

	<span class="ms-1">Empty Recycle Bin</span>
	<span class="ms-1">Empty recycle bin</span>

Uh oh!

Implement Recycle Bin #4168

Are you sure you want to change the base?

Implement Recycle Bin #4168

Uh oh!

Conversation

rohnsha0 commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

to be merged together:-

Uh oh!

mister-roboto commented Apr 29, 2025

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevepiercy commented Apr 29, 2025

Uh oh!

stevepiercy commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohnsha0 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohnsha0 commented May 6, 2025

Uh oh!

stevepiercy commented May 6, 2025

Uh oh!

petschki commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ale-rt commented May 8, 2025

Uh oh!

rohnsha0 commented May 9, 2025

Uh oh!

rohnsha0 commented May 9, 2025

Uh oh!

jensens commented May 9, 2025

Uh oh!

davisagli commented May 11, 2025

Uh oh!

davisagli commented May 11, 2025

Uh oh!

rohnsha0 commented May 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davisagli commented Jun 17, 2025

Uh oh!

rohnsha0 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohnsha0 commented Jul 10, 2025

Uh oh!

Uh oh!

rohnsha0 commented Apr 29, 2025 •

edited

Loading

stevepiercy commented Apr 29, 2025 •

edited

Loading

rohnsha0 commented May 6, 2025 •

edited

Loading

petschki commented May 7, 2025 •

edited

Loading

rohnsha0 commented Jun 17, 2025 •

edited

Loading