Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1138 starting classic-ui page templates #1139

Open
wants to merge 18 commits into
base: 6.0
Choose a base branch
from
Open

Conversation

flipmcf
Copy link

@flipmcf flipmcf commented Jan 15, 2022

Thank you for your contribution to the Plone Documentation.

Before submitting this PR, please make sure:

No - I am using markdown for plone 6 docs. Let's update this ^^^

Fixes: #

Improves: #1138 #1137

Changes proposed in this pull request:

*The page-templates directory under classic-ui
*The basic structure
*getting the PR process down.

@netlify
Copy link

netlify bot commented Jan 15, 2022

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit adb0571
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/662ed040eb018c000806999b
😎 Deploy Preview https://deploy-preview-1139--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review. I put in a couple of suggestions for your consideration.

I can do a full review once it is out of draft status.

.gitignore Outdated Show resolved Hide resolved
docs/classic-ui/page-templates/dtml.md Outdated Show resolved Hide resolved
docs/classic-ui/page-templates/index.md Outdated Show resolved Hide resolved
docs/classic-ui/page-templates/index.md Outdated Show resolved Hide resolved
docs/classic-ui/page-templates/index.md Outdated Show resolved Hide resolved
@MrTango MrTango self-assigned this Aug 29, 2022
@flipmcf flipmcf marked this pull request as ready for review November 28, 2022 15:58
insertion. To avoid this, use the ``structure:`` prefix:

```xml+genshi
<div>${structure: ...}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work as shorthand notation. See zopefoundation/Zope#1077. You have to use <div tal:content="structure ..." /> instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 56c9b95

@stevepiercy stevepiercy changed the base branch from 6-dev to 6.0 April 28, 2024 21:02
@stevepiercy
Copy link
Contributor

@flipmcf @MrTango what's the status of this PR? Let's finish it or close it as "won't fix". I updated the PR to point to the correct branch 6.0 and resolved conflicts.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update URL and markup to Chameleon docs.

docs/classic-ui/page-templates/index.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

@flipmcf I overhauled this documentation, but it still has serious technical and structural problems that I do not know how to resolve.

@plone/classicui-team please review and comment on my TODOs, and pay careful attention to the code examples, which are untested and may not actually work.

I would also greatly appreciate an honest critique of how this document should be structured or broken apart. It's a mix of tutorial, how-to guide, reference, and explanation, making it difficult to find exactly what you need.

If there is no review or update, I may gut this page, and provide a link to Page Templates and Customizing Existing Templates.

@stevepiercy
Copy link
Contributor

This PR seems to be abandoned.

We have begun sorting out the structure of documentation to align with the Diatáxis Framework. Parts of this PR may be reused to fall within that framework, but this PR needs a champion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants