-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1138 starting classic-ui page templates #1139
base: 6.0
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review. I put in a couple of suggestions for your consideration.
I can do a full review once it is out of draft status.
Co-authored-by: Steve Piercy <[email protected]>
insertion. To avoid this, use the ``structure:`` prefix: | ||
|
||
```xml+genshi | ||
<div>${structure: ...}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work as shorthand notation. See zopefoundation/Zope#1077. You have to use <div tal:content="structure ..." />
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 56c9b95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update URL and markup to Chameleon docs.
@flipmcf I overhauled this documentation, but it still has serious technical and structural problems that I do not know how to resolve. @plone/classicui-team please review and comment on my TODOs, and pay careful attention to the code examples, which are untested and may not actually work. I would also greatly appreciate an honest critique of how this document should be structured or broken apart. It's a mix of tutorial, how-to guide, reference, and explanation, making it difficult to find exactly what you need. If there is no review or update, I may gut this page, and provide a link to Page Templates and Customizing Existing Templates. |
This PR seems to be abandoned. We have begun sorting out the structure of documentation to align with the Diatáxis Framework. Parts of this PR may be reused to fall within that framework, but this PR needs a champion. |
Thank you for your contribution to the Plone Documentation.
Before submitting this PR, please make sure:
No - I am using markdown for plone 6 docs. Let's update this ^^^
Fixes: #
Improves: #1138 #1137
Changes proposed in this pull request:
*The page-templates directory under classic-ui
*The basic structure
*getting the PR process down.