Skip to content

Commit

Permalink
Merge pull request #37 from plone/move-icon-links-footer
Browse files Browse the repository at this point in the history
Move the icon links from the primary sidebar to the page content footer
  • Loading branch information
stevepiercy authored Nov 12, 2024
2 parents 9cf0a5d + d4ffac5 commit 63892a9
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 13 deletions.
24 changes: 17 additions & 7 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,17 +168,27 @@
html_theme = "plone_sphinx_theme"
html_logo = "_static/logo.svg"
html_favicon = "_static/favicon.ico"
# The default value includes icon-links, so override it with that one omitted, and add it to html_theme_options[footer_content_items].
html_sidebars = {
"**": [
"navbar-logo",
"search-button-field",
"sbt-sidebar-nav",
]
}
html_theme_options = {
"article_header_start": ["toggle-primary-sidebar"],
# "extra_navbar": """
# <p class="ploneorglink">
# <a href="https://plone.org">
# <img src="/_static/logo.svg" alt="plone.org" /> plone.org</a>
# </p>""",
"extra_footer": """<p>The text and illustrations in this website are licensed by the Plone Foundation under a Creative Commons Attribution 4.0 International license. Plone and the Plone® logo are registered trademarks of the Plone Foundation, registered in the United States and other countries. For guidelines on the permitted uses of the Plone trademarks, see <a href="https://plone.org/foundation/logo">https://plone.org/foundation/logo</a>. All other trademarks are owned by their respective owners.</p>
<p>Pull request previews by <a href="https://readthedocs.org/">Read the Docs</a>.</p>""",
# "navbar_center": ["chapter-title.html"],
"footer_end": ["version.html"],
"footer_content_items": [
"author",
"copyright",
"last-updated",
"extra-footer",
"icon-links",
],
# Uncomment for a page-wide footer
# "footer_end": ["version.html"],
"icon_links": [
{
"name": "GitHub",
Expand Down
1 change: 1 addition & 0 deletions news/37.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Move the icon links from the primary sidebar to the page content footer. @stevepiercy
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/**
* Icon links design for the footer, where it defaults in this theme.
*/
div.footer-item>ul.navbar-icon-links {
justify-content: center;
}
11 changes: 6 additions & 5 deletions src/plone_sphinx_theme/assets/styles/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
*/

// Use sphinx-book-theme SCSS as base
@import "sphinx-book-theme/index";
@use "sphinx-book-theme/index";

// Re-usable components across the theme
@import "components/title";
@use "components/icon-links";
@use "components/title";

@import "content/code";
@use "content/code";

@import "extensions/todo";
@import "extensions/video";
@use "extensions/todo";
@use "extensions/video";

Large diffs are not rendered by default.

0 comments on commit 63892a9

Please sign in to comment.