Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ILeadImage inherits from IImageScaleTraversable to enable the ima… #577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Dec 12, 2020

…ges view

Fixes #576

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Dec 12, 2020

This can be tested TTW by using the plips/plip-2454-dx-siteroot.cfg in buildout.coredev, enabling the leadimage behavior on the Plone site and adding an image.
Without this patch the view of the Plone site will be broken as described in #576.

@ale-rt
Copy link
Member Author

ale-rt commented Dec 12, 2020

@jenkins-plone-org please run jobs

@jensens
Copy link
Member

jensens commented Dec 18, 2020

Seems legit at a first look. And that said the question is, if we want to make all places where image fields are used explicit traversable:

At the moment this is set to all DX content - anyway if it has an image or not.
https://github.com/plone/plone.app.dexterity/blob/41498dc5113aeb465b31c816c9e8b369739a087c/plone/app/dexterity/configure.zcml#L49

Problem will occur on plone.supermodel (XML/TTW) based image fields then.
So this is not an option.
Ergo: I would add the <implements... as above for the site root instead of subclassing in the ILeadImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The lead image behavior does not work on the Plone site root
3 participants