-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not enable plone.allowdiscussion by default #665
Conversation
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
e2a313c
to
d17da8d
Compare
d17da8d
to
47b4833
Compare
47b4833
to
9d1b9e7
Compare
@jensens I think we need a new branch for Plone 6.0, before this is merged |
buildout.coredev 6.0 already points to 3.x branch:
No idea why meta still tests 6.0 |
All packages that are only meant for 6.1, should have this in
And then rerun plone/meta over it. I pushed a commit with those changes to this PR. |
lets do this when plone.app.discussion is installed.
see plone/plone.app.discussion#211
do not merge alone!