No longer set portal_properties.site_properties.visible_ids on site creation #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation. The ``portal_properties`` tools is deprecated, ``visible_ids`` was not set as real property, and usage of ``visible_ids`` was largely removed in Plone 5.0 already. You already can no longer set ``visible ids`` in the Editing control panel, nor in the member preferences. The only remaining use for ``visible_ids``, if set to true, was to show the page ids on the 'select default page' form.
This comment was marked as resolved.
This comment was marked as resolved.
|
@jenkins-plone-org please run jobs |
mauritsvanrees
added a commit
to plone/plone.app.content
that referenced
this pull request
Jun 6, 2024
Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member. This was using the deprecated ``portal_properties`` tool. See also plone/plone.app.contenttypes#693
mauritsvanrees
added a commit
to plone/Products.PlonePAS
that referenced
this pull request
Jun 6, 2024
jensens
approved these changes
Jun 7, 2024
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jun 7, 2024
Branch: refs/heads/master Date: 2024-06-07T00:07:41+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.PlonePAS@c03dccb Do not test with visible_ids boolean property, as this may get removed. See plone/plone.app.contenttypes#693 Files changed: A news/125.tests M src/Products/PlonePAS/tests/test_properties.py Repository: Products.PlonePAS Branch: refs/heads/master Date: 2024-06-07T05:45:44-04:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/Products.PlonePAS@f755f20 Merge pull request #88 from plone/remove-portal-properties-tool Do not test with visible_ids boolean property, as this may get removed. Files changed: A news/125.tests M src/Products/PlonePAS/tests/test_properties.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jun 7, 2024
Branch: refs/heads/master Date: 2024-06-07T00:07:41+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.PlonePAS@c03dccb Do not test with visible_ids boolean property, as this may get removed. See plone/plone.app.contenttypes#693 Files changed: A news/125.tests M src/Products/PlonePAS/tests/test_properties.py Repository: Products.PlonePAS Branch: refs/heads/master Date: 2024-06-07T05:45:44-04:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/Products.PlonePAS@f755f20 Merge pull request #88 from plone/remove-portal-properties-tool Do not test with visible_ids boolean property, as this may get removed. Files changed: A news/125.tests M src/Products/PlonePAS/tests/test_properties.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jun 7, 2024
Branch: refs/heads/master Date: 2024-06-06T23:32:52+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.content@87bd122 No longer check visible_ids on the 'select default page' form. Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member. This was using the deprecated ``portal_properties`` tool. See also plone/plone.app.contenttypes#693 Files changed: A news/125.bugfix M plone/app/content/browser/templates/select_default_page.pt Repository: plone.app.content Branch: refs/heads/master Date: 2024-06-07T05:47:09-04:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.content@a7a5cdd Merge pull request #283 from plone/remove-portal-properties-tool No longer check visible_ids on the 'select default page' form. Files changed: A news/125.bugfix M plone/app/content/browser/templates/select_default_page.pt
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jun 7, 2024
Branch: refs/heads/master Date: 2024-06-06T23:32:52+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.content@87bd122 No longer check visible_ids on the 'select default page' form. Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member. This was using the deprecated ``portal_properties`` tool. See also plone/plone.app.contenttypes#693 Files changed: A news/125.bugfix M plone/app/content/browser/templates/select_default_page.pt Repository: plone.app.content Branch: refs/heads/master Date: 2024-06-07T05:47:09-04:00 Author: Jens W. Klein (jensens) <[email protected]> Commit: plone/plone.app.content@a7a5cdd Merge pull request #283 from plone/remove-portal-properties-tool No longer check visible_ids on the 'select default page' form. Files changed: A news/125.bugfix M plone/app/content/browser/templates/select_default_page.pt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
portal_propertiestools is deprecated,visible_idswas not set as real property, and usage ofvisible_idswas largely removed in Plone 5.0 already. You already can no longer setvisible idsin the Editing control panel, nor in the member preferences. The only remaining use forvisible_ids, if set to true, was to show the page ids on the 'select default page' form.