Conversation
|
@ericof thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
| @@ -0,0 +1 @@ | |||
| -c https://dist.plone.org/release/6.0.13/constraints.txt | |||
There was a problem hiding this comment.
Your PR targets master which is only used for Plone 6.1
.meta.toml says 6.1-latest -- did you apply these changes using plone/meta?
There was a problem hiding this comment.
@jackahl I am not sure, it will be quite a mess if we have to update a version in each package after every Plone release. Personally I still use https://github.com/plone/buildout.coredev for working on core Plone backend packages.
There was a problem hiding this comment.
This should indeed be -c https://dist.plone.org/release/6.1-dev/constraints.txt to be in line with what .meta.toml and tox.ini say.
And indeed, I would use buildout.coredev for working on core Plone packages. Note that since recently this also has support for installing with pip/mxdev, though it may need some fine tuning in practice.
There was a problem hiding this comment.
Sorry, I merged PR #701, but did not realise that the current PR was part of it and still had open issues.
There was a problem hiding this comment.
@mauritsvanrees ah yes, I see how that happened by accident
5 participants
No description provided.