Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebDAV traversal #196

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix WebDAV traversal #196

merged 1 commit into from
Feb 26, 2024

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Feb 22, 2024

Fix a traversal error that happens when traversing a WebDAV resource and the virtual host monster is used.

Fixes #195

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Feb 22, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to work.

@ale-rt
Copy link
Member Author

ale-rt commented Feb 26, 2024

@jenkins-plone-org please run jobs

Fix a traversal error that happens when traversing a WebDAV resource and the virtual host monster is used.

Fixes #195
@ale-rt
Copy link
Member Author

ale-rt commented Feb 26, 2024

@jenkins-plone-org please run jobs

@ale-rt ale-rt merged commit 745f0a3 into master Feb 26, 2024
13 checks passed
@ale-rt ale-rt deleted the 195-bugfix branch February 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with webdav and Plone 6 when the site is published using virtual hosting
3 participants