Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button UI improved #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Button UI improved #95

wants to merge 3 commits into from

Conversation

Vansh-Baghel
Copy link

@Vansh-Baghel Vansh-Baghel commented Feb 4, 2023

For #94
GH

For #96
GH-Img

@Vansh-Baghel
Copy link
Author

@fredvd Could you review this PR?

@Vansh-Baghel
Copy link
Author

@ericof @fredvd Could you review it now?

@ericof
Copy link
Member

ericof commented Feb 6, 2023

Hello @Vansh-Baghel!

Could you please look at Contributors Agreement?

In order to contribute to code on the plone organization, we require you to be part of our core-dev team.

@Vansh-Baghel
Copy link
Author

@ericof Hey, I really can and want to contribute into this organization, but won't there be anything wrong if I submit the agreement right?
Coz I didn't understand what this means "I make no other express or implied warranty (including without limitation, in this disclaimer of warranty, any warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE)."

@stevepiercy
Copy link
Contributor

@Vansh-Baghel never signed the agreement. What do we do with this PR?

@rioksane
Copy link
Collaborator

@ericof Hey, I really can and want to contribute into this organization, but won't there be anything wrong if I submit the agreement right? Coz I didn't understand what this means "I make no other express or implied warranty (including without limitation, in this disclaimer of warranty, any warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE)."

Hi @Vansh-Baghel sorry for a really late answer, but if you have any questions regarding contributors agreement, please contact [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants