Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read json from request BODYFILE instead of BODY. #1731

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Read json from request BODYFILE instead of BODY. #1731

wants to merge 5 commits into from

Commits on Nov 2, 2023

  1. Read json from request BODYFILE instead of BODY. 

    This fixes a regression due to a low Zope form memory limit of 1MB used since Plone 6.0.7.
See `CMFPlone issue 3848 <https://github.com/plone/Products.CMFPlone/issues/3848>`_ and `Zope PR 1142 <https://github.com/zopefoundation/Zope/pull/1142>`_.
    @mauritsvanrees
    mauritsvanrees committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5bc5145 View commit details
    Browse the repository at this point in the history

  2. json_body: read the bodyfile from the beginning.

    @mauritsvanrees
    mauritsvanrees committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    617d443 View commit details
    Browse the repository at this point in the history

  3. Removed breakpoint

    @mauritsvanrees
    mauritsvanrees committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0e6f407 View commit details
    Browse the repository at this point in the history

  4. json_body: leave the bodyfile in the position where it was before we … 

    …started reading.
    @mauritsvanrees
    mauritsvanrees committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a1d75b4 View commit details
    Browse the repository at this point in the history

  5. json_body: read bodyfile ourselves, to check if it is empty. 

    Passing an empty bodyfile to json.load gives a ValueError.
    @mauritsvanrees
    mauritsvanrees committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    07821b8 View commit details
    Browse the repository at this point in the history