-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
folder_contents icons missing in classic UI after migration Products.CMFCore#3838 #337
Open
szakitibi
wants to merge
7
commits into
plone:master
Choose a base branch
from
szakitibi:import_missing_icons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b37b864
Update metadata.xml
szakitibi d3a7881
provide ugprades/216/registy/icons_plone.xml file
szakitibi df7f299
Create 216.zcml upgrade step
szakitibi 8e49f22
Include 216 upgrade step
szakitibi a0a5ac7
add change log
szakitibi df3b1fb
set purge false
szakitibi a8411b8
upgrade 216: do not purge existing icon values
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Fix missing folder_contents icons in classic UI after migration from Plone 5 - see also plone/Prodcuts.CMFPlone#3838 | ||
[szakitibi] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<configure | ||
xmlns="http://namespaces.zope.org/zope" | ||
xmlns:gs="http://namespaces.zope.org/genericsetup" | ||
> | ||
|
||
<gs:upgradeStep | ||
source="215" | ||
destination="216" | ||
title="Import PLIP 3211 icon changes" | ||
profile="plone.staticresources:default" | ||
handler=".upgrade_v215_to_v216" | ||
/> | ||
|
||
</configure> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from plone import api | ||
from plone.registry import field | ||
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
from plone.registry.record import Record | ||
|
||
|
||
def upgrade_v215_to_v216(context): | ||
"""Import missing icons.""" | ||
|
||
registry = api.portal.get_tool('portal_registry') | ||
|
||
if 'plone.icon.plone-rearrange' not in registry.records: | ||
registry.records['plone.icon.plone-rearrange'] = Record( | ||
field.TextLine(title='Plone Icon rearrange'), | ||
'++plone++bootstrap-icons/sort-down-alt.svg' | ||
) | ||
|
||
if 'plone.icon.plone-selection' not in registry.records: | ||
registry.records['plone.icon.plone-selection'] = Record( | ||
field.TextLine(title='Plone Icon selection'), | ||
'++plone++bootstrap-icons/list-ul.svg' | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be in a single line, otherwise it would break on pypi