improve extensibility and optimize stored data #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
I moved columns and fields out to be easily customized by a more specific adapter.
In redturtle.volto we do not store the whole object data in blocks when it's an internal link reference because infos in that object can be dynamic (for example the content has been renamed).
In deserializer we store only an object with the UID and in the serializer we expand it with ISerializeToJsonSummary/ISerializeToJson.
We store an object like this:
{"UID": "whatever"}
but in plone.volto you are storing the uid in @id..let's define a standard and i will fix it ;)
Are you interested in using the same pattern also here? Do you see some possible problems?
Is it better to expand items as summary (less fields) or having the full data?
@tiberiuichim @tisto @sneridagh