Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string interpolators #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

erral
Copy link
Member

@erral erral commented Apr 2, 2022

This PR adds 2 string interpolators, intended to be used in content-rule configuration. The interpolators provide access to the Volto portal url and the Volto absolute url of a content item.

These string interpolators are needed when running Plone in a path like /api to be able to configure content-rule actions correctly. For instance, think of a content-rule that sends an email after a content has been added to some folder. This email message includes the URL of the content object added. If Plone is running in /api the URL will include the /api part.

These interpolators use the existing volto.frontend_domain registry setting to produce the frontend url.

These interpolators are only needed when not running in seamless mode, that's why we created them, because back them our Volto was running on / and Plone in /api

Addresses #44

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral force-pushed the string-interpolators-for-volto-urls branch from e4a327f to a523e9d Compare April 2, 2022 14:40
@erral erral closed this Apr 2, 2022
@erral erral reopened this Apr 2, 2022
@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral force-pushed the string-interpolators-for-volto-urls branch 2 times, most recently from 96e9f10 to a64136b Compare April 2, 2022 14:53
@erral erral force-pushed the string-interpolators-for-volto-urls branch from a64136b to 317b747 Compare April 2, 2022 15:01
@erral erral marked this pull request as ready for review April 2, 2022 15:18
@erral
Copy link
Member Author

erral commented Apr 2, 2022

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants