Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment variable that defines the language of the site, in "make backend-docker-start" command #6747

Open
wesleybl opened this issue Feb 11, 2025 · 4 comments

Comments

@wesleybl
Copy link
Member

wesleybl commented Feb 11, 2025

The plone/plone-backend#170 PR changes the environment variable used to define the language of the portal when creating the Plone site with docker.

The make backend-docker-start command uses this variable. See:

docker run -it --rm --name=backend -p 8080:8080 -v volto-backend-data:/data -e SITE=Plone -e ADDONS='$(KGS)' -e LANGUAGE='$(LANGUAGE)' $(DOCKER_IMAGE)

After the PR is merged and use in Volto of a release that contains it, the command should be updated.

Documentation must be updated as well.

@wesleybl wesleybl changed the title Update Volto documentation on changing the environment variable for defining the language of the Plone site Update environment variable that defines the language of the site, in "make backend-docker-start" command Feb 12, 2025
@stevepiercy stevepiercy moved this from New to Todo in Plone Documentation Feb 12, 2025
@boss6825
Copy link
Member

I have Updated Makefile and developing-core.md (documentation) to replace LANGUAGE with SITE_LANGUAGE
Is it enough or Should i make changes somewhere else also in documentation ?
will create a PULL request then ...

@boss6825
Copy link
Member

I think i can't work on this issue as it has a new label of blocked ...

@stevepiercy
Copy link
Collaborator

@boss6825 you can work on it, but your PR wouldn't be merged until the PR on which it depends is merged.

@boss6825
Copy link
Member

@stevepiercy then i will submit the PR today and will do the required changes in future if required accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants