Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SITE_LANGUAGE environment variable instead of LANGUAGE #170

Open
wants to merge 1 commit into
base: 6.1.x
Choose a base branch
from

Conversation

wesleybl
Copy link
Member

The LANGUAGE variable is already set and used by the OS.

Fixes plone/volto#6404

The LANGUAGE variable is already set and used by the OS.
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change, but I think we should do it since the current environment variable conflicts with the one from Linux.

Once we have a release that includes this and update Volto to use it, we need to update the Makefile and docs in volto.

@stevepiercy
Copy link
Contributor

Once we have a release that includes this and update Volto to use it, we need to update the Makefile and docs in volto.

Can y'all create issues and either link to this PR or create sub-issues in plone/volto#6404?

@wesleybl
Copy link
Member Author

@stevepiercy I created plone/volto#6747

@stevepiercy
Copy link
Contributor

@wesleybl that issue captures the docs todo, but what of the Makefile todo?

@wesleybl
Copy link
Member Author

@wesleybl that issue captures the docs todo, but what of the Makefile todo?

@stevepiercy I've updated the issue to address both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants