Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editing frontend_domain setting #6647

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Fix editing frontend_domain setting #6647

merged 3 commits into from
Feb 5, 2025

Conversation

davisagli
Copy link
Member

Fixes #4171

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit bdc93a4
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67a306c1568d780008bca2e4

stevepiercy
stevepiercy approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a minute to find the setting.

I agree with using a TextWidget.

@davisagli
Copy link
Member Author

I'll go ahead and merge since I think this is uncontroversial and the previous test run passed before I updated the changelog.

@davisagli davisagli merged commit bcc1995 into main Feb 5, 2025
77 checks passed
@davisagli davisagli deleted the 4171-frontend-domain-widget branch February 5, 2025 06:38
@erral
Copy link
Member

erral commented Feb 9, 2025 •
edited
Loading

This is a candidate to backport to Volto 16, I would say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@avoinea avoinea Awaiting requested review from avoinea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't update frontend domain via Volto Settings
3 participants
@davisagli @erral @stevepiercy